change to the correct filemode for opening a binary file for output #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm looking at GloVe for the first time in a while…. In principle, happy to try to merge in changes so things work smoothly on Windows, but I also don't actually have a Windows dev environment with which to test things, so that confirmation that things work or don't work would be helpful. At any rate, this is a clear, simple, can't do any harm change…. Thanks! |
tarekeldeeb
pushed a commit
to tarekeldeeb/GloVe-Arabic
that referenced
this pull request
Mar 20, 2023
change to the correct filemode for opening a binary file for output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small step trying to move GloVe forward for correct I/O, especially on native Windows environment. A more comprehensive pull request (#12) has been standing for more than two years!